Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fargate complains when memory is exactly the minimum required. #5471

Closed
SPPearce opened this issue Nov 5, 2024 · 3 comments · Fixed by #5475
Closed

Fargate complains when memory is exactly the minimum required. #5471

SPPearce opened this issue Nov 5, 2024 · 3 comments · Fixed by #5475

Comments

@SPPearce
Copy link
Contributor

SPPearce commented Nov 5, 2024

Bug report

Fargate complains when the memory is exactly the minimum required.

Expected behavior and actual behavior

Using AWS Fargate, a spurious warning is produced when the minimum memory is provided.

Steps to reproduce the problem

Run:

nextflow run nextflow-io/hello -process.memory "2.GB" \
-bucket-dir '<BUCKET>' 

This will give warnings:

Program output

WARN: Process 'sayHello (4)' memory requirement of 2 GB is below the minimum allowed by Fargate of 2 GB
WARN: Process 'sayHello (1)' memory requirement of 2 GB is below the minimum allowed by Fargate of 2 GB
WARN: Process 'sayHello (3)' memory requirement of 2 GB is below the minimum allowed by Fargate of 2 GB
WARN: Process 'sayHello (2)' memory requirement of 2 GB is below the minimum allowed by Fargate of 2 GB

Environment

  • Nextflow version: 24.10.0
@SPPearce
Copy link
Contributor Author

SPPearce commented Nov 5, 2024

It looks like this line:

        if( mega <=slot.min ) {
            log.warn "Process '${task.lazyName()}' memory requirement of ${mem} is below the minimum allowed by Fargate of ${MemoryUnit.of(mega+'MB')}"

should be

        if( mega <slot.min ) {

@pditommaso
Copy link
Member

Well spotted! willing to create a PR for it?

@SPPearce
Copy link
Contributor Author

SPPearce commented Nov 5, 2024

Well spotted! willing to create a PR for it?

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants