From 9a4e42869dfa449b088b816c8503965f5489252e Mon Sep 17 00:00:00 2001 From: Brandon Price Date: Thu, 21 Sep 2023 17:39:20 +0000 Subject: [PATCH 1/2] Removed allow_other vulnerability --- .../cloud/google/batch/GoogleBatchScriptLauncher.groovy | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/nf-google/src/main/nextflow/cloud/google/batch/GoogleBatchScriptLauncher.groovy b/plugins/nf-google/src/main/nextflow/cloud/google/batch/GoogleBatchScriptLauncher.groovy index ae4dc6b5f6..c9ed889685 100644 --- a/plugins/nf-google/src/main/nextflow/cloud/google/batch/GoogleBatchScriptLauncher.groovy +++ b/plugins/nf-google/src/main/nextflow/cloud/google/batch/GoogleBatchScriptLauncher.groovy @@ -134,7 +134,7 @@ class GoogleBatchScriptLauncher extends BashWrapperBuilder implements GoogleBatc .setRemotePath(it) ) .setMountPath( "${MOUNT_ROOT}/${it}".toString() ) - .addAllMountOptions( ['-o rw,allow_other', '-implicit-dirs'] ) + .addAllMountOptions( ['-o rw', '-implicit-dirs'] ) .build() ) } From 8b42161271ad0936b9a902ad9806774ba6282916 Mon Sep 17 00:00:00 2001 From: Brandon Price Date: Thu, 21 Sep 2023 19:08:37 +0000 Subject: [PATCH 2/2] Removed allow_other from nf-google test --- .../cloud/google/batch/GoogleBatchScriptLauncherTest.groovy | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/nf-google/src/test/nextflow/cloud/google/batch/GoogleBatchScriptLauncherTest.groovy b/plugins/nf-google/src/test/nextflow/cloud/google/batch/GoogleBatchScriptLauncherTest.groovy index 62dfe74e04..7375728245 100644 --- a/plugins/nf-google/src/test/nextflow/cloud/google/batch/GoogleBatchScriptLauncherTest.groovy +++ b/plugins/nf-google/src/test/nextflow/cloud/google/batch/GoogleBatchScriptLauncherTest.groovy @@ -71,10 +71,10 @@ class GoogleBatchScriptLauncherTest extends Specification{ volumes.size() == 2 volumes[0].getGcs().getRemotePath() == 'alpha' volumes[0].getMountPath() == '/mnt/disks/alpha' - volumes[0].getMountOptionsList() == ['-o rw,allow_other', '-implicit-dirs'] + volumes[0].getMountOptionsList() == ['-o rw', '-implicit-dirs'] volumes[1].getGcs().getRemotePath() == 'omega' volumes[1].getMountPath() == '/mnt/disks/omega' - volumes[1].getMountOptionsList() == ['-o rw,allow_other', '-implicit-dirs'] + volumes[1].getMountOptionsList() == ['-o rw', '-implicit-dirs'] } }