You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We apparently never enabled the optional augur export v2 minification for production builds (an unfortunate oversight!). But even the automatic minification done by recent Augur versions is subverted by custom post-processing that explicitly outputs unminified (pretty-printed) JSON. Oops.
Adjust json.dump() and json.dumps() callsites to respect AUGUR_MINIFY_JSON (or alternatively to always minify)
Replace json.dump() and json.dumps() callsites with augur.utils.write_json() which brings the benefits of respecting AUGUR_MINIFY_JSON but also automatic minification by size… but we maybe probably kinda sorta should promote that to Augur's public API first.
Additional context @miparedes was having a heck of time getting his custom builds (based on an older version of this repo) to minify.
The text was updated successfully, but these errors were encountered:
Current Behavior
Dataset JSONs are not minified.
Minification would make a big difference in size:
We apparently never enabled the optional
augur export v2
minification for production builds (an unfortunate oversight!). But even the automatic minification done by recent Augur versions is subverted by custom post-processing that explicitly outputs unminified (pretty-printed) JSON. Oops.Expected behavior
All JSONs are minified.
Possible solution
json.dump()
andjson.dumps()
callsites to respectAUGUR_MINIFY_JSON
(or alternatively to always minify)json.dump()
andjson.dumps()
callsites withaugur.utils.write_json()
which brings the benefits of respectingAUGUR_MINIFY_JSON
but also automatic minification by size… but we maybe probably kinda sorta should promote that to Augur's public API first.Additional context
@miparedes was having a heck of time getting his custom builds (based on an older version of this repo) to minify.
The text was updated successfully, but these errors were encountered: