Rename H3 proposed subclades #268
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huddlej
temporarily deployed
to
refs/pull/268/merge
GitHub Actions
Inactive
Rename H3 subclade proposals for J.2 to use amino acid substitutions instead of single-letter suffixes.
huddlej
force-pushed
the
rename-h3-proposed-subclades
branch
from
27000ba to
4eea770
Compare
|
How useful is it to rename these now. when I was proposing to go with amino acid patterns, I was thinking to track haplotypes instead of clades. I'd suggest to revisit this in a few weeks and pick proper subclades. |
|
It's probably not useful now. Generally, I just need a way to quickly annotate proposed subclade annotations through Nextclade for the two frequency estimation methods we're using now. In the current approach, I have to update influenza-clade-nomenclature, update-merge-release the Nextclade dataset, and rerun Nextclade annotations. If we're concerned about updating the official flu Nextclade datasets with PRs like this, I could maintain separate parallel datasets just for proposed subclades. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename H3 subclade proposals for J.2 to use amino acid substitutions instead of single-letter suffixes.
Test URL: https://clades.nextstrain.org?dataset-name=flu_h3n2_ha&dataset-url=https://github.com/nextstrain/nextclade_data/tree/rename-h3-proposed-subclades/data_output/nextstrain/flu/h3n2/ha/EPI1857216/unreleased