Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme): menu overflow use clip #4373

Merged
merged 3 commits into from
Dec 16, 2024
Merged

Conversation

Peterl561
Copy link
Contributor

@Peterl561 Peterl561 commented Dec 16, 2024

Closes #4335

📝 Description

caused by #4105
setting overflow: hidden on an ancestor of a position: sticky element will make that ancestor the scroll reference
use overflow: clip instead, which is fairly well supported at time of writing

⛳️ Current behavior (updates)

header is sticky but still scrolls

before.mov

🚀 New behavior

header sticky works properly

after.mov

💣 Is this a breaking change (Yes/No):

No

📝 Additional Information

No tests as it's a scroll behavior

Summary by CodeRabbit

Summary by CodeRabbit

  • Bug Fixes

    • Improved the sticky behavior of the menu component by modifying the overflow handling.
  • New Features

    • Enhanced rendering and functionality of the menu component within the theme.

Copy link

changeset-bot bot commented Dec 16, 2024

🦋 Changeset detected

Latest commit: d8295a0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
@nextui-org/theme Patch
@nextui-org/autocomplete Patch
@nextui-org/checkbox Patch
@nextui-org/date-input Patch
@nextui-org/date-picker Patch
@nextui-org/form Patch
@nextui-org/input-otp Patch
@nextui-org/input Patch
@nextui-org/radio Patch
@nextui-org/select Patch
@nextui-org/table Patch
@nextui-org/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextui-docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 16, 2024 11:48am
nextui-storybook-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 16, 2024 11:48am

Copy link
Contributor

coderabbitai bot commented Dec 16, 2024

Walkthrough

The pull request introduces a modification to the @nextui-org/theme package, specifically in the menu.ts file. The change replaces the overflow-hidden CSS class with overflow-clip for the menu base component. This adjustment addresses an issue related to the sticky behavior of listbox sections, enhancing the rendering and functionality of menu components.

Changes

File Change Summary
packages/core/theme/src/components/menu.ts Replaced overflow-hidden with overflow-clip in the menu base class
.changeset/old-peas-cheat.md Patch file for the @nextui-org/theme package

Assessment against linked issues

Objective Addressed Explanation
Fix SelectSection sticky heading issue [#4335]

Possibly related PRs

Suggested labels

📋 Scope : Docs

Suggested reviewers

  • jrgarciadev

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6e96011 and d8295a0.

📒 Files selected for processing (1)
  • .changeset/old-peas-cheat.md (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • .changeset/old-peas-cheat.md

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@wingkwong wingkwong added this to the v2.6.9 milestone Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - SelectSection heading cannot be sticky anymore
2 participants