-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(theme): menu overflow use clip #4373
Conversation
fixes listbox section sticky not working
🦋 Changeset detectedLatest commit: d8295a0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThe pull request introduces a modification to the Changes
Assessment against linked issues
Possibly related PRs
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Closes #4335
📝 Description
caused by #4105
setting
overflow: hidden
on an ancestor of aposition: sticky
element will make that ancestor the scroll referenceuse
overflow: clip
instead, which is fairly well supported at time of writing⛳️ Current behavior (updates)
header is sticky but still scrolls
before.mov
🚀 New behavior
header sticky works properly
after.mov
💣 Is this a breaking change (Yes/No):
No
📝 Additional Information
No tests as it's a scroll behavior
Summary by CodeRabbit
Summary by CodeRabbit
Bug Fixes
New Features