Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NXsas: review NXcollimator group specification #523

Open
prjemian opened this issue Dec 30, 2016 · 1 comment
Open

NXsas: review NXcollimator group specification #523

prjemian opened this issue Dec 30, 2016 · 1 comment

Comments

@prjemian
Copy link
Contributor

The NXcollimator group specification might be good for some neutron sources but is not general. A better choice for some data might be NXaperture (like the recent change in NXcanSAS). The application definition should account for the difference between an aperture (2-D device) and a collimator (3-D device).

@prjemian prjemian modified the milestone: NXDL 3.4 Jun 30, 2017
@prjemian prjemian modified the milestones: NXDL 2018.3, later Jan 30, 2018
@mkoennecke
Copy link
Contributor

The whole NXsas is outdated. The collimator still uses the deprecated NXgeometry way of doing things. In NXdetector and NXsample there is still equatorial_angle which we since have retired in favor of meridional angle. The whole positioning may need review in terms of NXtransformations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants