Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated env versions of rmarkdownnotebook #154

Merged
merged 3 commits into from
Aug 25, 2023
Merged

Updated env versions of rmarkdownnotebook #154

merged 3 commits into from
Aug 25, 2023

Conversation

WackerO
Copy link
Collaborator

@WackerO WackerO commented Aug 24, 2023 •
edited
Loading

Small PR to update the notebook env

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/differentialabundance branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Aug 24, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅

Posted for pipeline commit e08278f

+| ✅ 158 tests passed       |+

✅ Tests passed:

Run details

  • nf-core/tools version 2.9
  • Run at 2023-08-25 05:20:06

pinin4fjords
pinin4fjords approved these changes Aug 24, 2023
View reviewed changes
Copy link
Member

@pinin4fjords pinin4fjords left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WackerO
Copy link
Collaborator Author

WackerO commented Aug 25, 2023

Thanks!

@WackerO WackerO merged commit dcf587b into nf-core:dev Aug 25, 2023
@WackerO WackerO deleted the rmarkdown_update branch August 25, 2023 05:34
@pinin4fjords pinin4fjords added this to the 1.3.0 milestone Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinin4fjords pinin4fjords pinin4fjords approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@WackerO @pinin4fjords