From 74fdcaab90fd1eec90d55fcf2aa197e77b7e1267 Mon Sep 17 00:00:00 2001
From: Adam Talbot <12817534+adamrtalbot@users.noreply.github.com>
Date: Mon, 29 Jan 2024 17:00:23 +0000
Subject: [PATCH 1/2] Fixup for PR #253

---
 .github/workflows/ci.yml | 14 --------------
 CHANGELOG.md             |  1 +
 2 files changed, 1 insertion(+), 14 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 715800c8..12343148 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -97,20 +97,6 @@ jobs:
         run: |
           echo ${{ steps.list.outputs.tags }}
 
-  # define_nxf_versions:
-  #   name: Choose nextflow versions to test against depending on target branch
-  #   runs-on: ubuntu-latest
-  #   outputs:
-  #     matrix: ${{ steps.nxf_versions.outputs.matrix }}
-  #   steps:
-  #     - id: nxf_versions
-  #       run: |
-  #         if [[ "${{ github.event_name }}" == "pull_request" && "${{ github.base_ref }}" == "dev" && "${{ matrix.NXF_VER }}" != "latest-everything" ]]; then
-  #           echo matrix='["latest-everything"]' | tee -a $GITHUB_OUTPUT
-  #         else
-  #           echo matrix='["latest-everything", "23.04.0"]' | tee -a $GITHUB_OUTPUT
-  #         fi
-
   test:
     name: ${{ matrix.tags }} ${{ matrix.profile }} NF-${{ matrix.NXF_VER }}
     needs: [changes]
diff --git a/CHANGELOG.md b/CHANGELOG.md
index d512d75c..e1e9f8ee 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -27,6 +27,7 @@ Thank you to everyone else that has contributed by reporting bugs, enhancements
 - [PR #246](https://github.com/nf-core/fetchngs/pull/246) - Handle dark/light mode for logo in GitHub README properly
 - [PR #248](https://github.com/nf-core/fetchngs/pull/248) - Update pipeline level test data path to use mirror on s3
 - [PR #249](https://github.com/nf-core/fetchngs/pull/249) - Update modules which includes absolute paths for test data, making module level test compatible within the pipeline.
+- [PR #253](https://github.com/nf-core/fetchngs/pull/253) - Add implicit tags in nf-test files for simpler testing strategy
 
 ### Software dependencies
 

From a78310f0080a3c8b1ad9777735998e3051301795 Mon Sep 17 00:00:00 2001
From: Adam Talbot <12817534+adamrtalbot@users.noreply.github.com>
Date: Mon, 29 Jan 2024 17:22:03 +0000
Subject: [PATCH 2/2] CHANGELOG

---
 CHANGELOG.md | 1 +
 1 file changed, 1 insertion(+)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index e1e9f8ee..9d2e0a9a 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -28,6 +28,7 @@ Thank you to everyone else that has contributed by reporting bugs, enhancements
 - [PR #248](https://github.com/nf-core/fetchngs/pull/248) - Update pipeline level test data path to use mirror on s3
 - [PR #249](https://github.com/nf-core/fetchngs/pull/249) - Update modules which includes absolute paths for test data, making module level test compatible within the pipeline.
 - [PR #253](https://github.com/nf-core/fetchngs/pull/253) - Add implicit tags in nf-test files for simpler testing strategy
+- [PR #258](https://github.com/nf-core/fetchngs/pull/258) - Fixes for [PR #253](https://github.com/nf-core/fetchngs/pull/253)
 
 ### Software dependencies