From dfb2d1574d057b4503127f4ea7b564aa09aca03e Mon Sep 17 00:00:00 2001 From: tdanhorn Date: Mon, 27 Jan 2025 11:17:44 -0700 Subject: [PATCH] Merge intervals for WES in GATK GenomicsDBImport (#1777) ## PR checklist - [x] This comment contains a description of changes (with reason). - [ ] If you've fixed a bug or added code that should be tested, add tests! - [ ] If you've added a new tool - have you followed the pipeline conventions in the [contribution docs](https://github.com/nf-core/sarek/tree/master/.github/CONTRIBUTING.md) - [ ] If necessary, also make a PR on the nf-core/sarek _branch_ on the [nf-core/test-datasets](https://github.com/nf-core/test-datasets) repository. - [x] Make sure your code lints (`nf-core pipelines lint`). - [ ] Ensure the test suite passes (`nextflow run . -profile test,docker --outdir `). - [ ] Check for unexpected warnings in debug mode (`nextflow run . -profile debug,test,docker --outdir `). - [ ] Usage Documentation in `docs/usage.md` is updated. - [ ] Output Documentation in `docs/output.md` is updated. - [x] `CHANGELOG.md` is updated. - [ ] `README.md` is updated (including new tool citations and authors/contributors). Running sarek with `--joint_germline` on WES samples with an intervals file containing many thousands of targets causes GATK `GenomicsDBImport` to create millions of files and run for several days without completing. Adding the `--merge-intervals` option to that process fixes that. This PR add the parameter conditional on the `--wes` pipeline parameter. Closes #1776 --------- Co-authored-by: Thomas Co-authored-by: Friederike Hanssen --- CHANGELOG.md | 1 + conf/modules/joint_germline.config | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6f3161eb42..72195563fa 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -14,6 +14,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Changed - [1767](https://github.com/nf-core/sarek/pull/1767) - Bump nf-schema version to 2.2.1 +- [1777](https://github.com/nf-core/sarek/pull/1777) - Merge intervals for WES in GATK GenomicsDBImport ### Fixed diff --git a/conf/modules/joint_germline.config b/conf/modules/joint_germline.config index 61a296721d..b3f5bffc8b 100644 --- a/conf/modules/joint_germline.config +++ b/conf/modules/joint_germline.config @@ -16,7 +16,9 @@ process { withName: 'GATK4_GENOMICSDBIMPORT' { - ext.args = { '--genomicsdb-shared-posixfs-optimizations true --bypass-feature-reader' } + ext.args = { params.wes ? + '--merge-input-intervals --genomicsdb-shared-posixfs-optimizations true --bypass-feature-reader' : + '--genomicsdb-shared-posixfs-optimizations true --bypass-feature-reader' } ext.prefix = { "${meta.intervals_name}.joint" } publishDir = [ enabled: false