Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove aws_tower profile from AWS megatests Github Actions in pipeline template #2138

Closed
drpatelh opened this issue Dec 21, 2022 · 3 comments

Comments

@drpatelh
Copy link
Member

drpatelh commented Dec 21, 2022

Description of feature

Just realised we are using -profile test_full,aws_tower for the automated AWS megatests:

Do we still need this if the CE has already been defined in Tower? 🤔 See it was added mostly to overwrite the trace files but they should be unique now anyway in most pipelines because they are named by timestamp? Removing aws_tower from those profiles should be ok no?

Originally added by Gisela and reviewed by Phil here:
nf-core/configs#256

@drpatelh
Copy link
Member Author

Gisela suggested on Slack that it should be fine to remove it but would be good to test it first. Could maybe use the test-pipeline for that.

@ewels
Copy link
Member

ewels commented Dec 21, 2022

Could presumably also delete the profile from configs 👍🏻

@mirpedrol
Copy link
Member

Done in #2287

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants