Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add template information to .nf-core.yml file #2359

Closed
Tracked by #2340
mirpedrol opened this issue Jul 3, 2023 · 3 comments
Closed
Tracked by #2340

Add template information to .nf-core.yml file #2359

mirpedrol opened this issue Jul 3, 2023 · 3 comments
Assignees
@mirpedrol
Labels
enhancement infrastructure template nf-core pipeline/component template
Milestone
2.10

Comments

@mirpedrol
Copy link
Member

Description of feature

When the creation of a pipeline is customized, the information is now stored in a file pipeline_template.yml. We should store this information in the .nf-core.yml file under a new tag template.
Lint that the deprecated pipeline_template.yml file doesn't exist.
@mirpedrol mirpedrol added template nf-core pipeline/component template enhancement infrastructure labels Jul 3, 2023
@mirpedrol mirpedrol added this to the 2.10 milestone Jul 3, 2023
@awgymer
Copy link
Contributor

awgymer commented Jul 5, 2023 •
edited
Loading

Would this then be auto-detected by commands that currently take a --template-yaml param?

@mirpedrol
Copy link
Member Author

Would this then be auto-detected by commands that currently take a --template-yaml param?

We should take this into account. Reading the current pipeline_template.yml file and adding the info to .nf-core.yml before removing it.

@mirpedrol mirpedrol self-assigned this Aug 3, 2023
This was referenced Aug 4, 2023
Closed
Merged
Merged
@mirpedrol
Copy link
Member Author

This is now done by #2388 and #2389
@awgymer if you are using this feature and would like to try it out with your pipeline, let us know your feedback :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mirpedrol mirpedrol

Labels
enhancement infrastructure template nf-core pipeline/component template
Projects
None yet
Milestone
2.10
Development

No branches or pull requests
2 participants
@mirpedrol @awgymer