Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linting modules/subworkflows - add failure when no snapshots for versions #2814

Closed
maxulysse opened this issue Feb 29, 2024 · 3 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@maxulysse
Copy link
Member

Description of the bug

the versions of tools is highly reproducible on docker/singularity, but it's often a lottery in conda.
I'd like a linting test that ensure we snapshot for modules, either:

  • process.out.versions
  • process.out (only since it contains versions)

we snapshot for subworkflows either:

  • workflow.out.versions
  • workflow.out (only since it contains versions)

Command used and terminal output

No response

System information

No response

@maxulysse maxulysse added the bug Something isn't working label Feb 29, 2024
@maxulysse
Copy link
Member Author

Note:
For subworkflows, we don't always use modules, so only a warning.
For subworkflows, snapshotting versions could be empty in some tests if we skip all the tools from said subworkflow.

@mahesh-panchal
Copy link
Member

Wasn't it an issue for bumping modules since then the snapshot wouldn't match ? If you checked if the output matched a regex, then that should be fine too for autobumping modules?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants