Remove the on_pull_request_target trigger from the download test.

[MatthiasZepper]

Admittedly, I had used GitHub Copilot to pick the triggers for the Download test workflow. However, it turns out that running on pull_request_target is useless, since the download test will only be run on the release PRs from dev to main. and a released pipeline should have passed that test before.

Additionally, I am removing the edited web hook, since editing the text of the PR description is not really a useful trigger for testing the download.

PR checklist

• This comment contains a description of changes (with reason)
• CHANGELOG.md is updated
• If you've fixed a bug or added code that should be tested, add tests!
• Documentation in docs is updated

[mirpedrol]

LGTM

[mirpedrol]

LGTM, thanks!

[mirpedrol]

I am looking at the failing test now 👀

[MatthiasZepper]

I am looking at the failing test now 👀

I hope you fixed it, but I somehow can't launch a workflow run with the GH Action version from my branch in this repo.

This works, because it is my fork:

 gh workflow run -R "MatthiasZepper/tools" --ref "download_action_trigger_refactor" "pytest.yml"

but

 gh workflow run -R "nf-core/tools" --ref "refs/pull/3399/head" "pytest.yml"

doesn't.

Unfortunately, I have no clue what the correct ref would be. Neither refs/pull/3399, refs/heads/pull/3399, pull/3399/head:download_action_trigger_refactor, MatthiasZepper:download_action_trigger_refactor nor MatthiasZepper/tools:download_action_trigger_refactor seem to work.

[mirpedrol]

Hi @MatthiasZepper, I just pushed the fix.
Why do you want to launch the action? tests are running on the PR CI

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.44%. Comparing base (0ede9d5) to head (09b9e2a).
Report is 21 commits behind head on dev.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[MatthiasZepper]

Hi @MatthiasZepper, I just pushed the fix. Why do you want to launch the action? tests are running on the PR CI

I was confused about the failing test, because I recalled that you had before already modified the CI to adapt it to that change, and thus attributed that failure to an old version of the CI. To my best knowledge, it will always run the CI from main, which is why I wanted to launch a custom run with the workflow file from my branch to prove that it would pass there. But if you managed now like this, there is indeed no reason. Happy to merge!