Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the ! prefix to manifest.version linting #506

Closed
jfy133 opened this issue Feb 5, 2020 · 1 comment
Closed

Allow the ! prefix to manifest.version linting #506

jfy133 opened this issue Feb 5, 2020 · 1 comment

Comments

@jfy133
Copy link
Member

jfy133 commented Feb 5, 2020

Problem

The nextflow check against manifest.version doesn't actually stop the pipeline with a helpful error message if a users version doesn't use the specify version unless ! is specified before the >=, as described here: https://www.nextflow.io/docs/latest/config.html?highlight=manifest#nextflow-version

Howeve linting fails if !, is included.

Solution

It would be nice if ! would also be accepted by linting on this line (thanks for @drpatelh for pointing towards it):

if self.config.get('manifest.nextflowVersion', '').strip('"\'').startswith('>='):

(Note: I'm not familar with python and don't have much time atm so not comfortable making a PR myself yet).

Alternative

Current workaround, add the following to main.nf

https://www.nextflow.io/docs/latest/metadata.html#nextflow-metadata

@ewels
Copy link
Member

ewels commented Feb 6, 2020

Fixed 🎉

@ewels ewels closed this as completed Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants