Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong export_plots value in multiqc_config.yaml #555

Closed
mashehu opened this issue Feb 21, 2020 · 4 comments
Closed

wrong export_plots value in multiqc_config.yaml #555

mashehu opened this issue Feb 21, 2020 · 4 comments
Labels
template nf-core pipeline/component template

Comments

@mashehu
Copy link
Contributor

mashehu commented Feb 21, 2020

I ran into the following error after the template sync:

Missing output file(s) `multiqc_plots` expected by process `multiqc (1)`

When changing export_plots value in multiqc_config.yaml from true to True it worked, see nf-core/rnaseq#200

Not sure if it is really a bug, but at least I ran into it and it looks like it is still like that in the template.

@ewels
Copy link
Member

ewels commented Feb 21, 2020

That is odd. I was under the impression that YAML didn't care about the upper or lower case of true. Indeed if I do a quick test in Python that seems to be the case:

>>> import yaml
>>> y_string = '''
... var_1: true
... var_2: True
... var_3: truee
... '''
>>>
>>> yaml.safe_load(y_string)
{'var_1': True, 'var_2': True, 'var_3': 'truee'}

@ewels
Copy link
Member

ewels commented Feb 21, 2020

Just tested MultiQC locally with two multiqc_config.yaml files and it generated the exported plots with both true and True.

Could you check in the working directory and see the contents of multiqc_config.yaml please? Also paste the MultiQC log file?

@ewels ewels added the template nf-core pipeline/component template label Feb 21, 2020
@mashehu
Copy link
Contributor Author

mashehu commented Feb 21, 2020

argh, now it worked also with the old mulitqc_config.yaml. Sorry for bothering you.

@mashehu mashehu closed this as completed Feb 21, 2020
@ewels
Copy link
Member

ewels commented Feb 21, 2020

Ok phew 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
template nf-core pipeline/component template
Projects
None yet
Development

No branches or pull requests

2 participants