-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GitHub PR comment with failing lint #714
Comments
Maybe everything is fine..? nf-core/gwas#3 (comment) |
Ok, so I finally tracked this down after a lot of debugging. There is no problem with the code, it's a limitation of GitHub actions. When a pull-request is created, the actor is the user / repo that the PR is coming from. That's who is running the action. If the PR comes from within the nf-core organisation (eg. from the We could fix this by asking everyone with a fork to make an auth token and set it as a secret on their forked repo, but that's never going to happen. Some people make a dedicated GitHub app which people can register with, but that's way too much work. So for now I think we leave it as it is - comments will appear on branch PRs but not fork PRs. We are not the only people to be affected by this - there are a lot of threads about it on the GitHub community forum. There are some fairly extreme workarounds that some people have made. Hopefully this will be addressed in a nicer way in the future. |
Here's the workaround that someone made that I referenced: https://stackoverflow.com/a/61450807/713980 Repo: https://github.com/nyurik/auto_pr_comments_from_forks |
NB: If that repo does get rewritten as a stable GitHub action then we could save the markdown to a file (we already have support for this) and then use the action to post it. That would be fairly trivial... 🤔 |
This PR should have a comment about failing tests: https://github.com/nf-core/chipseq/pull/177/checks?check_run_id=929475596
Figure out why that didn't happen..
The text was updated successfully, but these errors were encountered: