Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] investigation file deviates from ISA #107

Closed
Brilator opened this issue Feb 18, 2022 · 2 comments
Closed

[BUG] investigation file deviates from ISA #107

Brilator opened this issue Feb 18, 2022 · 2 comments

Comments

@Brilator
Copy link
Member

Brilator commented Feb 18, 2022

Describe the bug
I've spotted two little deviations from the original ISA Model specs in the isa.investigation.xlsx produced by arcCommander. (Possibly also relevant for ISADotNet?):

  1. Study Protocol Parameters Name (lines 74, 75 in investigation.xlsx)
  • ARC
Study Protocol Parameters Term Accession Number
Study Protocol Parameters Term Source REF
Study Protocol Parameters Name Term Accession Number
Study Protocol Parameters Name Term Source REF	
  1. PubMed ID (lines 13, 44)
  • ARC
Investigation Publication PubMed ID
---
Study Publication PubMed ID
  • ISA
Investigation PubMed ID
---
Study PubMed ID

For 2., the arcCommander version is actually more coherent than the original regarding other Publication keys.

@HLWeil
Copy link
Member

HLWeil commented Feb 21, 2022

Hey, thanks for pointing this out!

Regarding 1.: This is actually a bit weird if you check the Protocol section in the link again.. By their specification, my header without the Name is correct (This is what I used as a basis for my implementation). But in the example they provided themselves, the Name is included.

Regarding 2: This incoherence kind of really annoys me 😄. Maybe we could ask the guys at ISA for their reasoning behind this, and whether this is up for debate? In general getting into contact with them might be beneficial.
Adjusting this in ISADotNet is of course the quick alternative

@HLWeil
Copy link
Member

HLWeil commented Nov 17, 2023

@HLWeil HLWeil closed this as completed Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants