Adding basic support for Narrators on Dropdown #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anjmao
requested changes
Apr 10, 2018
There was a problem hiding this comment.
@hartra344 Thanks a lot. Looks, good, I will test it locally and merge later today.
| .toBe(select.itemsList.markedItem.htmlId); | ||
| })); | ||
|
|
||
| it('should set aria-activedecendant equal to chosen item on arrow up', fakeAsync(() => { |
There was a problem hiding this comment.
oops, you're right!
|
Also just a quick note. This method of narration support does not currently work with Apple's Voice Over. Here is a webkit bug about that: https://bugs.webkit.org/show_bug.cgi?id=167671 . Couldn't find a better method on this kind of control though and it's what the CDK team uses. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #216