Skip to content

Commit

Permalink
feat(manual_typings): instead of override global use node type defs
Browse files Browse the repository at this point in the history
  • Loading branch information
Hotell committed Jan 10, 2016
1 parent 4934dd8 commit 4835e59
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 4 deletions.
4 changes: 1 addition & 3 deletions core.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
import './manual_typings/globals.d.ts'

export * from './src/facade/facade';
//export * from './src/facade/facade';
export * from './src/core/di';
export { Attr, Input, Output, HostBinding, HostListener, Directive, Component } from './src/core/directives';
export { Pipe, PipeTransform } from './src/core/pipes';
6 changes: 5 additions & 1 deletion manual_typings/globals.d.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
declare var global: any;
// TODO: ideally the node.d.ts reference should be scoped only for files that need and not to all
// the code including client code
/// <reference path="../typings/browser/ambient/node/node.d.ts" />

// @TODO add angular1 module overrides for proper ...provide handling

interface BrowserNodeGlobal {
Object: typeof Object,
Expand Down
1 change: 1 addition & 0 deletions typings.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
"devDependencies": {
},
"ambientDependencies": {
"node": "https://raw.githubusercontent.com/DefinitelyTyped/DefinitelyTyped/master/node/node.d.ts",
"chai": "https://raw.githubusercontent.com/DefinitelyTyped/DefinitelyTyped/master/chai/chai.d.ts",
"mocha": "https://raw.githubusercontent.com/DefinitelyTyped/DefinitelyTyped/master/mocha/mocha.d.ts",
"sinon": "https://raw.githubusercontent.com/DefinitelyTyped/DefinitelyTyped/master/sinon/sinon.d.ts",
Expand Down

0 comments on commit 4835e59

Please sign in to comment.