-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add alt text criteria to style guide #119
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview will be available once build job completes!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The guidelines read incredibly excessively, and like a negatively-framed shopping list of specific mistakes someone has made in the past instead of positively-framed advice on how to do things well.
There are three sentences dedicated just to punctuation. Line 418 already includes a lot of the critical information needed to write alt text, too.
We could just just be linking to the WAI Tips & Tricks instead.
Thoughts:
|
Should is a very loaded word because we haven't instituted Vale as a requirement for documentation pull requests. If it's intended to be, then the effort of this PR is premature optimization. I don't have any reason to treat GitLab as an authority just because they already did it. I would have raised the same objections there, too. While the WAI Tips & Tricks are probably a bit too general, it is also part of the W3C, which is the actual authority that defines how browsers should behave. This also means that they define how the web should be accessible, and I am thus more inclined to treat them as a primary source of advice or information. If 418 is too long, it should be reworked or removed: I don't feel that a list of items should have preferential "weight" over a paragraph just because the formatting is different. |
More recent style guides for UIs are moving towards "Do/Don't" lists. And by definition, they include "negative" inputs. What I'm proposing, based on GitLab guidance, is no different. IMO, the discussion of "should" and the reformatting of line 418 is besides the point (and a distraction). Writers need these types of lists so they know what to do, and what not to do.
|
Proposed changes
Add criteria for alt text to the style guide at https://github.com/nginx/documentation/blob/main/templates/style-guide.md
Checklist
Before merging a pull request, run through this checklist and mark each as complete.
README.md
andCHANGELOG.md
)Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation.
Please refer to our style guide for guidance about placeholder content.