Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Note to include PR in changelog #1034

Closed
ciarams87 opened this issue Sep 5, 2023 · 0 comments · Fixed by #1574
Closed

Note to include PR in changelog #1034

ciarams87 opened this issue Sep 5, 2023 · 0 comments · Fixed by #1574
Assignees
@lucacome
Labels
refined Requirements are refined and the issue is ready to be implemented. release-engineering Relates to all release engineering tasks size/medium Estimated to be completed within a week
Milestone
v1.2.0

Comments

@ciarams87
Copy link
Contributor

ciarams87 commented Sep 5, 2023 •
edited by mpstefan
Loading

As a maintainer of NGF
I want to label my PR with a note label
So that NGF maintainers can highlight changes they make to be included as part of the changelog for release.

Acceptance:

  • Create a Label for PR's that need a note in the change log
  • The PR template is updated to include a note about the label for changelog inclusion.
  • Update the pull request documentation to include the importance of including the label on an important PR.
@ciarams87 ciarams87 added enhancement New feature or request and removed enhancement New feature or request labels Sep 5, 2023
@mpstefan mpstefan added the release-engineering Relates to all release engineering tasks label Oct 5, 2023
@mpstefan mpstefan added the size/extra-small Estimated to be completed within a day label Dec 19, 2023
@mpstefan mpstefan added this to the v1.2.0 milestone Dec 19, 2023
@mpstefan mpstefan changed the title Improve release automation Note to include PR in changelog Dec 20, 2023
@mpstefan mpstefan added size/medium Estimated to be completed within a week refined Requirements are refined and the issue is ready to be implemented. and removed size/extra-small Estimated to be completed within a day labels Feb 5, 2024
@lucacome lucacome self-assigned this Feb 13, 2024
@lucacome lucacome mentioned this issue Feb 14, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucacome lucacome

Labels
refined Requirements are refined and the issue is ready to be implemented. release-engineering Relates to all release engineering tasks size/medium Estimated to be completed within a week
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging a pull request may close this issue.

Add release-note section in PR template lucacome/nginx-kubernetes-gateway
3 participants
@lucacome @mpstefan @ciarams87