Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit tests fail #2625

Closed
lucacome opened this issue Sep 30, 2024 · 3 comments · Fixed by #2685
Closed

Unit tests fail #2625

lucacome opened this issue Sep 30, 2024 · 3 comments · Fixed by #2685
Assignees
@sjberman
Labels
refined Requirements are refined and the issue is ready to be implemented. tests Pull requests that update tests
Milestone
v1.5.0

Comments

@lucacome
Copy link
Member

lucacome commented Sep 30, 2024 •
edited
Loading

The unit tests are randomly failing with

--- FAIL: TestUpdateControlPlane (0.00s)
    --- FAIL: TestUpdateControlPlane/change_log_level (0.00s)
        config_updater_test.go:99: 
            Expected
                <chan string | len:1, cap:1>: 0xc00030a8c0
            to be empty
Running Suite: Static Suite - /home/runner/work/nginx-gateway-fabric/nginx-gateway-fabric/internal/mode/static
==============================================================================================================
Random Seed: 1727711008

Examples of failure:
@bjee19
Copy link
Contributor

bjee19 commented Sep 30, 2024

Should we close #2624 for this issue, they are the same.

@lucacome
Copy link
Member Author

oh I didn't see the other one, yeah we should keep just one of the two

@bjee19
Copy link
Contributor

bjee19 commented Sep 30, 2024

There is a little more information on this one, so I will close the other in favor of this.

@bjee19 bjee19 mentioned this issue Sep 30, 2024
Closed
@mpstefan mpstefan added tests Pull requests that update tests refined Requirements are refined and the issue is ready to be implemented. labels Oct 7, 2024
@mpstefan mpstefan added this to the v1.5.0 milestone Oct 7, 2024
@sjberman sjberman self-assigned this Oct 14, 2024
@sjberman sjberman mentioned this issue Oct 14, 2024
Merged
6 tasks
@lucacome lucacome moved this to ✅ Done in NGINX Gateway Fabric Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sjberman sjberman

Labels
refined Requirements are refined and the issue is ready to be implemented. tests Pull requests that update tests
Projects
NGINX Gateway Fabric
Status: ✅ Done
Milestone
v1.5.0
Development

Successfully merging a pull request may close this issue.

Fix failing unit test sjberman/nginx-gateway-fabric
4 participants
@lucacome @mpstefan @sjberman @bjee19