Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git is required for installation #278

Open
alexandrupaler opened this issue Feb 28, 2020 · 6 comments
Open

git is required for installation #278

alexandrupaler opened this issue Feb 28, 2020 · 6 comments
Assignees
Labels
documentation Documentation

Comments

@alexandrupaler
Copy link
Contributor

If somebody downloads the code in a zip file and does not have git installed, the installer does not work. The install.md document should mention that git is prerequisite.

autoconf script should also check this, because git is necessary for preparing the compilation of the pypi package.

@95-martin-orion
Copy link
Contributor

autoconf script should also check this, because git is necessary for preparing the compilation of the pypi package.

Agreed. Before this I think we assumed that the user had git installed (how else would they have cloned the repo?) but with the PyPI package we need to double-check.

@alexandrupaler
Copy link
Contributor Author

how else would they have cloned the repo?

I used to download zip files of the repo from github

@s-mandra
Copy link
Member

git is not strictly required to run qflex, but some scripts like check_format.sh require it. I'm ok to either remove the check from configure.ac add it to the list of required software.

@alexandrupaler
Copy link
Contributor Author

alexandrupaler commented Feb 29, 2020

git is required to compile qflexcirq because the code includes a submodule. compilation is almost always required each time the user downloads qflexcirq from pypi. for this reason there I had to add two lines that invoke git in the setup.py file.

@s-mandra
Copy link
Member

git is required to compile qflexcirq because the code includes a submodule. compilation is almost always required each time the user downloads qflexcirq from pypi. for this reason there I had to add two lines that invoke git in the setup.py file.

Got it. I didn't know about this. Let's add it to install.md (configure already checks for its installation).

@alexandrupaler
Copy link
Contributor Author

There is also a docopt in requirements.txt. Should we treat docopt like pybind and not use submodules but pypi package instead? This could also speed-up compilation of python wheels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation
Projects
None yet
Development

No branches or pull requests

3 participants