Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix memory management #9

Open
dlyongemallo opened this issue Apr 24, 2019 · 0 comments
Open

fix memory management #9

dlyongemallo opened this issue Apr 24, 2019 · 0 comments
Labels
wontfix This will not be worked on

Comments

@dlyongemallo
Copy link
Contributor

Pointer ownership should be clarified using, e.g., std::unique_ptr. Right now, scratch pointers are being passed around all over the place, and it's not clear what the chain of ownership is. (The pointers are also just NULLed at the end, without any deletes.)
@s-mandra s-mandra added the wontfix This will not be worked on label Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dlyongemallo @s-mandra