From c7e14063cd1099a4a407f5f44c5181438d64b51d Mon Sep 17 00:00:00 2001 From: EV Date: Mon, 1 Apr 2019 16:02:08 +0200 Subject: [PATCH] feat(router-store): Make usage of forRoot required (#1662) (#1672) Closes #1662 BREAKING CHANGES: usage of forRoot is now required for StoreRouterConnectingModule BEFORE: ```ts @NgModule({ imports: [ StoreRouterConnectingModule ] }) export class AppModule {} ``` AFTER: ```ts @NgModule({ imports: [ StoreRouterConnectingModule.forRoot() ] }) export class AppModule {} ``` --- .../router-store/src/router_store_module.ts | 25 ++++++------------- 1 file changed, 7 insertions(+), 18 deletions(-) diff --git a/modules/router-store/src/router_store_module.ts b/modules/router-store/src/router_store_module.ts index fc4376fff3..ff482d219e 100644 --- a/modules/router-store/src/router_store_module.ts +++ b/modules/router-store/src/router_store_module.ts @@ -122,7 +122,7 @@ enum RouterTrigger { * { path: '', component: SimpleCmp }, * { path: 'next', component: SimpleCmp } * ]), - * StoreRouterConnectingModule + * StoreRouterConnectingModule.forRoot() * ], * bootstrap: [AppCmp] * }) @@ -130,23 +130,7 @@ enum RouterTrigger { * } * ``` */ -@NgModule({ - providers: [ - { - provide: _ROUTER_CONFIG, - useValue: {}, - }, - { - provide: ROUTER_CONFIG, - useFactory: _createRouterConfig, - deps: [_ROUTER_CONFIG], - }, - { - provide: RouterStateSerializer, - useClass: DefaultRouterStateSerializer, - }, - ], -}) +@NgModule({}) export class StoreRouterConnectingModule { static forRoot< T extends BaseRouterStoreState = SerializedRouterStateSnapshot @@ -157,6 +141,11 @@ export class StoreRouterConnectingModule { ngModule: StoreRouterConnectingModule, providers: [ { provide: _ROUTER_CONFIG, useValue: config }, + { + provide: ROUTER_CONFIG, + useFactory: _createRouterConfig, + deps: [_ROUTER_CONFIG], + }, { provide: RouterStateSerializer, useClass: config.serializer