Cannot use previous defined methods in withComputed

[muuvmuuv]

Which @ngrx/* package(s) are the source of the bug?

signals

Minimal reproduction of the bug/regression with instructions

I am trying to use a method defined through withMethods in a withComputed. Unfortunately it seems the type inference is not there, so I cannot use the method in the spread operator.

export const FilterStepStore = signalStore(
	withState(initialState),
	withSyncStorage('filter-step-store'),
	withMethods((store) => ({
		stepMetsRequirements(step: FilterStep): boolean {
			for (const requirement of step.require) {
				const value = store[requirement]
				if (isEmpty(value)) {
					return false
				}
			}
			return true
		},
	})),
	withComputed(({ stepMetsRequirements, nextStep }) => {
		return {
			canActivateNext: computed(() => {
				const ns = nextStep()
				if (!ns) {
					return false
				}
				return stepMetsRequirements(ns)
			}),
		}
	}),
)

Expected behavior

Access methods in computed as it works the other way around.

Versions of NgRx, Angular, Node, affected browser(s) and operating system(s)

To that time all on latest

Other information

No response

I would be willing to submit a PR to fix this issue

• Yes
• No

[rainerhahnekamp]

@muuvmuuv, we do not expose methods in withComputed because you should not run any side-effects (and methods usually do that) there.

Although not ideal, but can you put stepMetsRequirements into withProps or even better: Does stepMetsRequirements really require an argument for step? Because if not, it could be a simple computed which internally uses nextStep.

[muuvmuuv]

Yeah, unfortunately the property is required so I am able to check against any and void redundant code. withProps works, as far as I can see there are no significant side effects. But I need to test it a little more, just migrated all ComponentStore code to two different signal stores.

[rainerhahnekamp]

@muuvmuuv, yes then please use withProps as the current solution-to-go. Moving this issue to the Q&A