Take ownership of NgRx-specific rules in ESLint plugin for RxJS? #4689
JasonWeinzierl
started this conversation in
General
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
The long-standing ESLint plugin for RxJS,
eslint-plugin-rxjs
, hasn't been updated in a few years, and so a couple forks have popped up. I've started a fork myself, and I'm taking the chance to do the types of breaking changes/reorganization that a hard fork can do. One of the organizational choices I'm reviewing is where to put NgRx-specific rules that have existed alongside mainline RxJS rules since the beginning.The existing rules are:
no-unsafe-catch
no-unsafe-switchmap
no-unsafe-first
no-cyclic-action
*(*
no-cyclic-action
actually already has a counterpart in the NgRx ESLint plugin: https://ngrx.io/guide/eslint-plugin/rules/avoid-cyclic-effects .)Would NgRx be interested in taking these rules on, into their own ESLint plugin? Are these exclusively useful to NgRx, or do they share utility with another library (e.g. the existing docs claim these rules work with redux-observable, but that project seems to have fallen into maintenance mode)? And are these rules even still useful in modern code?
Related poll under the repo itself: JasonWeinzierl/eslint-plugin-rxjs-x#132
Beta Was this translation helpful? Give feedback.
All reactions