Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(StoreDevTools): rename action list filters #1589

Merged
merged 1 commit into from
Apr 1, 2019

Conversation

timdeschryver
Copy link
Member

@timdeschryver timdeschryver commented Feb 28, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #1557

What is the new behavior?

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Other information

BREAKING CHANGE:

actionsWhitelist is renamed to actionsSafelist
actionsBlacklist is renamed to actionsBlocklist

BEFORE:

StoreDevtoolsModule.instrument({
  actionsWhitelist: ['...'],
  actionsBlacklist: ['...']
})

AFTER:

StoreDevtoolsModule.instrument({
  actionsSafelist: ['...'],
  actionsBlocklist: ['...']
})

@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.527% when pulling 4c46c7a on pr/devtools-filter-lists into 1613f50 on master.

@ngrxbot
Copy link
Collaborator

ngrxbot commented Feb 28, 2019

Preview docs changes for 4c46c7a at https://previews.ngrx.io/pr1589-4c46c7a/

@jsonberry
Copy link

jsonberry commented Mar 4, 2019

LGTM 👍

Edit: might want to add a "Fixes #1557" in the commit 🤷‍♂️

BREAKING CHANGE:

`actionsWhitelist` is renamed to `actionsSafelist`
`actionsBlacklist` is renamed to `actionsBlocklist`

BEFORE:

```ts
StoreDevtoolsModule.instrument({
  actionsWhitelist: ['...'],
  actionsBlacklist: ['...']
})
```

AFTER:

```ts
StoreDevtoolsModule.instrument({
  actionsSafelist: ['...'],
  actionsBlocklist: ['...']
})
```
@brandonroberts brandonroberts force-pushed the pr/devtools-filter-lists branch from 4c46c7a to 86a4c1f Compare April 1, 2019 13:09
@ngrxbot
Copy link
Collaborator

ngrxbot commented Apr 1, 2019

Preview docs changes for 86a4c1f at https://previews.ngrx.io/pr1589-86a4c1f/

@brandonroberts brandonroberts merged commit 5581826 into master Apr 1, 2019
@brandonroberts brandonroberts deleted the pr/devtools-filter-lists branch April 1, 2019 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Store Devtools: Rename actionBlacklist / actionsWhitelist options
5 participants