Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@ngrc/component Refactor cdAware factory #2443

Closed
5 tasks
BioPhoton opened this issue Mar 20, 2020 · 1 comment
Closed
5 tasks

@ngrc/component Refactor cdAware factory #2443

BioPhoton opened this issue Mar 20, 2020 · 1 comment

Comments

@BioPhoton
Copy link
Contributor

BioPhoton commented Mar 20, 2020

Make sure it is aligned with the current way of creating factories.
It would be good to consult @alex-okrushko for detailed requirements.

Todo

  • Refactored out things related to ngZone or optimizations in Ivy
    • Change pipe config argument to a string
  • Adopt pipe and let
  • Updte tests
    • Remove ivy and zone related tests

Related: #2441

I would be willing to submit a PR for the docs ❤️

[x] Yes (Assistance is provided if you need help submitting a pull request)
[ ] No

@BioPhoton
Copy link
Contributor Author

BioPhoton commented Mar 30, 2020

Hi @alex-okrushko

please have a look at #2458. If this incorporates all your wished I would be working directly on that and we could close both.

Especially important for you is the section "New Internals" at the bottom of the first comment.

Thanks for your time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants