Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@ngrx/component Implement tests work for Ivy, ViewEngine, NgZone, NgNoopZone, zone free environment #2445

Closed
BioPhoton opened this issue Mar 21, 2020 · 1 comment

Comments

@BioPhoton
Copy link
Contributor

BioPhoton commented Mar 21, 2020

@ngrx/component Make tests work for Ivy, ViewEngine, NgZone, NgNoopZone, no zone environment

Minimal reproduction of the bug/regression with instructions:

We neep proper unit tests to ensure the cone works in:

  • Ivy in:
  • ViewEngine in:
    • ZoneFull environment where Angulars zone service is of type NgZone
    • ZoneLess environment where Angulars zone service is of type NgNoopZone

See current state for e.g. the push pipe here:
https://github.com/ngrx/platform/blob/master/modules/component/spec/push/push.pipe.spec.ts#L226

Expected behavior:

All tests are implemented and pass.

Related: #2441

I would be willing to submit a PR to fix this issue

[x] Yes (Assistance is provided if you need help submitting a pull request)
[ ] No

@BioPhoton
Copy link
Contributor Author

Closed as strategies got redecided and so this needs a new issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants