feat(component-store): accept error type in tapResponse

[markostanimirovic]

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our guidelines: https://github.com/ngrx/platform/blob/master/CONTRIBUTING.md#commit
• Tests for the changes have been added (for bug fixes / features)
• Documentation has been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

The input argument of tapResponse error callback cannot be typed directly.

Closes #3051

What is the new behavior?

The input argument of tapResponse error callback can be typed directly:

tapResponse(
  () => {},
  (error: { message: string }) => console.error(error.message),
),

If not passed, the type of error will be unknown, just like the current tapResponse implementation.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

[ngrxbot]

Preview docs changes for b07fe7f at https://previews.ngrx.io/pr3056-b07fe7f7/

[fgoulet]

With this change, my code does not compile anymore and I don't understand how to fix it.

TS2345: Argument of type '(error: HttpErrorResponse) => void' is not assignable to parameter of type '<E = unknown>(error: E) => void'.   Types of parameters 'error' and 'error' are incompatible.     Type 'E' is not assignable to type 'HttpErrorResponse'.

     tapResponse(
            (newEquipmentItem) => {
               ....
            },
            (error: HttpErrorResponse) => {
             ....
            }
    )

[markostanimirovic]

Thanks for reporting this @fgoulet.

It compiles in ngrx/platform repo because noStrictGenericChecks is set to true 🤦‍♂️

I'll raise the fix PR.

[brandonroberts]

We should update that strict check in the repo also if Angular's default is more strict, so we're on the same baseline at least.