-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(store): add selectSignal method for interop with Angular Signals #3856
Conversation
✅ Deploy Preview for ngrx-io canceled.
|
958fab5
to
b54b042
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
0ed9f47
to
26776da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks much better now! 🤘
projects/example-app/src/app/books/containers/collection-page.component.ts
Outdated
Show resolved
Hide resolved
26776da
to
dbd3c2a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #
What is the new behavior?
Introduces the
Store.selectSignal()
method for returning a signal of the provided selector functionselect
operator that uses thelift
on theObservable
to create a new instance of theStore
. This is done outside the injection context, causing the error.Does this PR introduce a breaking change?
Other information
Converted almost entire NgRx example-app to use
Store.selectSignal()
for exploring, but will revert most of it.