Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(data): DefaultDataService getAll httpOptions fix + test #4134

Merged
merged 5 commits into from
Nov 19, 2023

Conversation

Tom-Neo
Copy link
Contributor

@Tom-Neo Tom-Neo commented Nov 15, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

DefaultDataService getAll handle HttpOptions when provided

Closes #4126

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x ] No

Other information

Copy link

netlify bot commented Nov 15, 2023

Deploy Preview for ngrx-io canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit f873c77
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/6554df8a9b895800094911ba

@brandonroberts brandonroberts changed the title fix(data) DefaultDataService getAll httpOptions fix + test fix(data): DefaultDataService getAll httpOptions fix + test Nov 19, 2023
@brandonroberts brandonroberts merged commit 213e4c9 into ngrx:main Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DefaultDataService HttpOptions
3 participants