Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type 'string' cannot be used to index type 'EffectsMetadata<T>' #518

Closed
jupiter101 opened this issue Oct 21, 2017 · 2 comments
Closed

Type 'string' cannot be used to index type 'EffectsMetadata<T>' #518

jupiter101 opened this issue Oct 21, 2017 · 2 comments

Comments

@jupiter101
Copy link

jupiter101 commented Oct 21, 2017

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report  
[ ] Feature request
[ ] Documentation issue or request

What is the current behavior?

Effects module masterbranch does not compile


{ Error: Command failed: "D:\dev\js\angular\platform\node_modules\.bin\ngc" -p ./modules/effects/tsconfig-build.json
Error at D:/dev/js/angular/platform/modules/effects/src/effects_metadata.ts:56:5: Type 'string' cannot be used to index type 'EffectsMetadata'.

    at ChildProcess.exithandler (child_process.js:204:12)
    at emitTwo (events.js:106:13)
    at ChildProcess.emit (events.js:191:7)
    at maybeClose (internal/child_process.js:886:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:226:5)
  killed: false,
  code: 1,
  signal: null,
  cmd: '"D:\\dev\\js\\angular\\platform\\node_modules\\.bin\\ngc" -p ./modules/effects/tsconfig-build.json' }

failing statement: metadata[propertyName] = { dispatch };

Expected behavior:

Compile

Minimal reproduction of the problem with instructions:

  1. Checkout master
  2. npm install
  3. npm run build

Version of affected browser(s),operating system(s), npm, node and ngrx:

win7, node v6.10.3, npm 3.10.10, ngrx/platform (master)

@jupiter101
Copy link
Author

jupiter101 commented Oct 21, 2017

okay compiles with

  1. Checkout master
  2. npm install
  3. npm run clean
  4. npm run build
    but run in a different error when building

    { Error: Command failed: "D:\dev\js\angular\platform\node_modules.bin\uglifyjs" -c -m --screw-ie8 --comments -o ./dist/store/bundles/store.umd.min.js --source-map ./dist/store/bundles/store.umd.min.j
    s.map --source-map-include-sources ./dist/store/bundles/store.umd.js --in-source-map ./dist/store/bundles/store.umd.js.map
    INFO: Using file from the input source map: store.umd.js
    (node:40128) DeprecationWarning: util.error is deprecated. Use console.error instead.
    D:\dev\js\angular\platform\node_modules\directory-encoder\node_modules\uglify-js\bin\uglifyjs:226
    sys.error("ERROR: can't read file: " + filename);

ReferenceError: filename is not defined
at ReadFileContext.callback (D:\dev\js\angular\platform\node_modules\directory-encoder\node_modules\uglify-js\bin\uglifyjs:226:52)
at FSReqWrap.readFileAfterOpen [as oncomplete] (fs.js:366:13)

at ChildProcess.exithandler (child_process.js:204:12)
at emitTwo (events.js:106:13)
at ChildProcess.emit (events.js:191:7)
at maybeClose (internal/child_process.js:886:16)
at Process.ChildProcess._handle.onexit (internal/child_process.js:226:5)

killed: false,
code: 1,
signal: null,
cmd: '"D:\dev\js\angular\platform\node_modules\.bin\uglifyjs" -c -m --screw-ie8 --comments -o ./dist/store/bundles/store.umd.min.js --source-map ./dist/store/bundles/store.umd.min.js.map --so
urce-map-include-sources ./dist/store/bundles/store.umd.js --in-source-map ./dist/store/bundles/store.umd.js.map' }


A little bit of documentation probably may help here...

@jupiter101
Copy link
Author

finally now in #519

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant