Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to set weekend days #516

Open
abozanona opened this issue Feb 19, 2020 · 9 comments
Open

Add ability to set weekend days #516

abozanona opened this issue Feb 19, 2020 · 9 comments
Labels
Category: Options Feature New features to implement

Comments

@abozanona
Copy link

Version: v1.12.11

Current Behavior

Current code sets first & last day in the week as weekend days function isWeekend

isWeekend: function(day) {
    return day === 0 || day === 6;
},

Wanted Behavior

It't be great if I can enter custom weekend days(Pass an array of numbers I want to mark as weekend).

@jungeun-cho
Copy link
Contributor

I think 'weekend' means Saturday and Sunday.
Why do you need weekend customization?

Do you just want to mark different days of the week as weekends?

@abozanona
Copy link
Author

In our system, Some countries weekend days are Saturday and Sunday, some other countries have Friday and Saturday as their weekend days and some countries only have Friday.

I could see that there's an option in the calendar to hide weekends, and that depends on isWeekend function.

I want to mark specific days as weekends, and hide them when narrowWeekend is true

@jungeun-cho jungeun-cho added the Feature New features to implement label Feb 20, 2020
@jungeun-cho
Copy link
Contributor

Ah! I undertand.
TOAST UI Calendar 2.0 is expected to support this feature. :)

@abozanona
Copy link
Author

Great! Do you know when will v2.0 approx. be released?

@dongsik-yoo
Copy link
Contributor

@abozanona It will take long time. I'm rewriting this calendar with virtual dom. There are many features those are hard to explain briefly, so check this article.

@dongsik-yoo
Copy link
Contributor

@abozanona I'll let you know if there is more specific release date.

@pythiantech
Copy link

Would be great to have this feature as the application we are developing is to be used in a country where Friday and Saturday are considered as weekend.

@luayjal
Copy link

luayjal commented Aug 19, 2022

@jungeun-cho @dongsik-yoo
now, are you support this feature or any way to off some days and hide some days?

@adhrinae
Copy link
Contributor

@luayjal
We don't have any plan for those features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Options Feature New features to implement
Projects
None yet
Development

No branches or pull requests

6 participants