Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cdn integration shouldn't include surrogate-key for presigned URLs #98

Closed
dbarrosop opened this issue Jul 5, 2022 · 0 comments · Fixed by #103
Closed

cdn integration shouldn't include surrogate-key for presigned URLs #98

dbarrosop opened this issue Jul 5, 2022 · 0 comments · Fixed by #103

Comments

@dbarrosop
Copy link
Member

Presigned URLs are meant to expire when the presigned URL expires, by setting the Surrogate-Control header in the response we are breaking this premise.

For now I have a VCL snippet to workaround this issue in production but we should fix hasura-storage instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fastly middleware: dont set surrogate control header for presigned urls nhost/hasura-storage
1 participant
@dbarrosop