Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Read and append table data #36

Merged
merged 7 commits into from
Dec 5, 2022
Merged

feat: Read and append table data #36

merged 7 commits into from
Dec 5, 2022

Conversation

mure
Copy link
Contributor

@mure mure commented Dec 5, 2022

What does this Pull Request accomplish?

  • append_table_data and get_table_data implemented

What testing has been done?

  • Added automated test that writes data and then reads back a mocked response. The mock is a temporary solution until the service supports manual flushing of data.
  • Manually tested reading data

Questions for reviewers

Any opinions on the method names? I'm open to alternatives. (write_table_data, read_table_data)

Are there other test cases we should cover?

@mure mure merged commit d7a7642 into master Dec 5, 2022
@mure mure deleted the append-read-data branch December 5, 2022 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spanglerco spanglerco spanglerco approved these changes

@cameronwaterman cameronwaterman cameronwaterman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mure @spanglerco @cameronwaterman