Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClientScript stops working after updating to 10.8.5 #46

Closed
LeviSnoot opened this issue Sep 25, 2022 · 2 comments
Closed

ClientScript stops working after updating to 10.8.5 #46

LeviSnoot opened this issue Sep 25, 2022 · 2 comments

Comments

@LeviSnoot
Copy link

LeviSnoot commented Sep 25, 2022

I updated to Jellyfin 10.8.5 a few hours ago, and since then I have been unable to get scrubbing to return. I've manually injected <script plugin="Jellyscrub" version="1.0.0.0" src="/Trickplay/ClientScript"></script> to index.html, restarted JF and cleared browser cookies and cache for my server. When I play a video, everything behaves as if ClientScript isn't there. I can navigate to https://server.com/Trickplay/ClientScript and it shows up there. Not seeing any mention of Jellyscrub or ClientScript in my browsers inspector either, which I normally would.

EDIT: Looking at the source for index.html, I can conclude that the injected script does not appear there. This is odd given that I did clear cookies and cache and when I open the file in my jellyfin folder, the script is there. I have however seen similar behaviour before and maybe the solution is editing main.jellyfin.bundle.js instead of index.html since in my experience the changes do stick better from there. I unfortunately am not skilled enough at javascript yet to know where one could inject the script in that file however.

@LeviSnoot
Copy link
Author

For now I have remedied this using #42 as this seems like the most consistent way of doing it. Thanks @tam1m!

I'll keep this open in case someone not using nginx runs into the same issue.

@nicknsy
Copy link
Owner

nicknsy commented Nov 27, 2022

Unable to reproduce this issue when upgrading to 10.8.7 and on a new 10.8.7 install. Not sure if this was version specific or just a random occurrence but I'll close the issue in a couple of days unless you've experienced this further.

@nicknsy nicknsy closed this as completed Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants