Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App review #1

Open
nidhi1608 opened this issue Apr 2, 2014 · 1 comment
Open

App review #1

nidhi1608 opened this issue Apr 2, 2014 · 1 comment

Comments

@nidhi1608
Copy link
Owner

/cc @nesquena

The app is feature complete, please review. Features, screenshots and time spent can be found in the attached README file.

Note: For the compose a tweet view, it wasn't clear if the original twitter app uses an activity or full screen modal dialog. So, I just took the simple route here and chose to work with an activity.

Known issues:

  1. Favorite button functionality is not implemented yet, so clicking on the star button doesn't do anything in the list view as well as detail view.

Thanks,
Nidhi

@nesquena
Copy link

nesquena commented Apr 2, 2014

Want to make a special note here since you submitted an excellent project, implementing many of the optionals. I fully understand and appreciate that most everyone in this class has full-time work and many other obligations in their lives, which makes those who are able to submit polished versions by the deadline earn my respect that much more. Really hope you found this project to be a great learning experience.

A few notes after checking out the code:

  • Your attention to detail and UI here was noted
  • Good to see you were able to format the timestamp cleanly
  • Great use of the ViewHolder pattern in your adapter
  • Nice to see you used a PullToRefresh library for easy timeline refreshes
  • Good to see you refreshed the timeline after composing a new tweet
  • Nice touch with the character count being calculated for Compose
  • Good to see you added ActiveAndroid annotations to the models

Here's a detailed Project 3 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. Hopefully by now you feel pretty comfortable with all the major pieces to basic Android apps (Views, Controllers, ActionBar, Navigation, Models, Authentication, API Communication, Persistence, et al) and see how they all fit together. We are close now to a turning point in the course where you should be hitting a "critical mass" towards your knowledge of Android.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants