Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile editor changes in the client UI are reverted due to being temporary offline / socket.io call #4252

Closed
PieterGit opened this issue Feb 2, 2019 · 0 comments
Labels
Milestone

Comments

@PieterGit
Copy link
Contributor

PieterGit commented Feb 2, 2019

Describe the bug
Changes to the profile disappear if the user is temporarily offline and the profilesocket.io is called

To Reproduce
Steps to reproduce the behavior:

  1. Edit a profile /profile, e.g. change the name of the profile.
  2. Disconnect the clients Internet connection (remove network cable or disable WiFi)
  3. Wait approx 30 seconds
  4. Console log shows GET /socket.io/?EIO=3&transport=polling&t=XXX net::ERR_INTERNET_DISCONNECTED
  5. Connect client Internet connection
  6. Your changes to the profile are reverted to the saved profile

Expected behavior
Profile changes should not be reverted on the screen due to being temporary offline or socket.io updates.

Your setup information

  • Nightscout 0.11-dev
  • Tested with Chrome

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants