v1.0.0-rc.2 breaks PR #1083

[ywmail]

Please follow the general troubleshooting steps first:

• You are using the latest version
• You are testing using the non-minified version of html2canvas and checked any potential issues reported in the console

Bug reports:

v1.0.0-rc.2 breaks PR #1083, v1.0.0-rc.1 is good.

regression made by this:

html2canvas/src/css/layout/bounds.ts

Lines 18 to 26 in 9a63797

	static fromClientRect(clientRect: ClientRect): Bounds {
	return new Bounds(clientRect.left, clientRect.top, clientRect.width, clientRect.height);
	}
	}
	export const parseBounds = (node: Element): Bounds => {
	return Bounds.fromClientRect(node.getBoundingClientRect());
	};

Specifications:

• html2canvas version tested with: v1.0.0-rc.3, v1.0.0-rc.2, v1.0.0-rc.1, v1.0.0-rc.0
• Browser & version:
• Operating system:

[ywmail]

code from v1.0.0-rc.1 is like this:

    static fromClientRect(clientRect: ClientRect, scrollX: number, scrollY: number): Bounds {
        return new Bounds(clientRect.left + scrollX, clientRect.top + scrollY, clientRect.width, clientRect.height);
    }
}

export const parseBounds = (node: Element, scrollX: number, scrollY: number): Bounds => {
    return Bounds.fromClientRect(node.getBoundingClientRect(), scrollX, scrollY);
};

[hakimio]

Maybe you should create a new pull request with the fix for this regression?