Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support retries #902

Open
firefart opened this issue Nov 26, 2024 · 1 comment
Open

Support retries #902

firefart opened this issue Nov 26, 2024 · 1 comment
Labels
affects/core Issue or PR related to the core of the library. type/feature New feature or request

Comments

@firefart
Copy link
Contributor

firefart commented Nov 26, 2024

Is your feature request related to a problem? Please describe.
As most notification services are HTTP based and there can be network issues, it would be nice to have a retry option to retry each service x times on error. A global retry over all services would be bad as it can result in double messages if only one service failed, so it should be per service.

Describe the solution you'd like
A retry count with an configurable additional sleep in between retries. The retry should be per service

Describe alternatives you've considered

Additional context

@nikoksr
Copy link
Owner

nikoksr commented Dec 2, 2024

Hi @firefart, thanks for the issue. I'm actively working on a design for a v2 of the library. This design already includes and supports features like retries, message templating, and others.

I'll upload a PoC asap and ping you when I did. Would love your feedback on the design at that point. Cheers.

@nikoksr nikoksr added type/feature New feature or request affects/core Issue or PR related to the core of the library. labels Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects/core Issue or PR related to the core of the library. type/feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants