mksysb: improve visibility on the output (ansible-collections#6269)

* mksysb: improve visibility on the output * add changelog frag
nilsding · Apr 5, 2023 · a64e368 · a64e368
1 parent 7d19eca
commit a64e368
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/changelogs/fragments/6269-mksysb-output.yml b/changelogs/fragments/6269-mksysb-output.yml
@@ -0,0 +1,2 @@
+minor_changes:
+  - mksysb - improved the output of the module in case of errors (https://github.com/ansible-collections/community.general/issues/6263).
diff --git a/plugins/modules/mksysb.py b/plugins/modules/mksysb.py
@@ -146,8 +146,7 @@ def __init_module__(self):
     def __run__(self):
         def process(rc, out, err):
             if rc != 0:
-                self.do_raise("mksysb failed.")
-            self.vars.msg = out
+                self.do_raise("mksysb failed: {0}".format(out))
 
         runner = CmdRunner(
             self.module,
@@ -158,6 +157,8 @@ def process(rc, out, err):
                      'extended_attrs', 'backup_crypt_files', 'backup_dmapi_fs', 'new_image_data', 'combined_path'],
                     output_process=process, check_mode_skip=True) as ctx:
             ctx.run(combined_path=[self.vars.storage_path, self.vars.name])
+            if self.verbosity >= 4:
+                self.vars.run_info = ctx.run_info
 
         self.changed = True
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		minor_changes:
		- mksysb - improved the output of the module in case of errors (https://github.com/ansible-collections/community.general/issues/6263).