-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Warnings (Height-Graph/ Draw Text) #166
Comments
Can I work on this issue? |
Yah sure. Wait for mentors to assign you the issue. |
Sure, please go ahead. Getting rid of errors is always good. |
@hs7898753 I modifyed the code to make sure we don't see the error when user tries to open the height graph without mentioning the Waypoints. I used the Valhalla.FOSSGIS.Server.Demo.App.-.Google.Chrome.2023-04-02.21-25-49.mp4Do you know any solution to this? Else I can use the |
I think @nilsnolde can help you in better way. |
@hs7898753 I used react-toastify and this is the output I got. I think it looks cool, do let me know about the warning message. Valhalla.FOSSGIS.Server.Demo.App.-.Google.Chrome.2023-04-02.22-42-23.mp4 |
Yah! This looks good👏 |
@hs7898753 Can you tell me what's the function of this method in line 640. Its being called from this line. |
I think this is just to update the longitude-latitudes when the edit, drag, remove is triggered |
Jep, I agree, it's better to move to the package that's maintained.
On the right button panel you can draw polygons on the map which should be avoided by the route/isochrone. That's the function updating that polygon. |
Should I change the welcome toast and use react-toastify? And uninstall the react-semantic-toasts package? |
That'd be great! In case you wanna do that, I'd suggest to raise another PR to do that first, as it's mostly a refactoring. Then we can merge it here and focus on the functional changes. How does that sound? |
Sure! |
Description
What is the problem you are facing
currently, height-graph feature is displaying an error message when it is used without a selected route.
Even some sort of compilation error comes when we use Draw Text.
What is your suggested solution
It should not display an compilation error message. Instead, it should display a warning message to select a route first.
Screenshots
Valhalla.FOSSGIS.Server.Demo.App.-.Brave.2023-04-01.11-32-32.mp4
The text was updated successfully, but these errors were encountered: