Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the "sample project generating" from "after merging new PRs into develop" to "directly refreshing the updates on each PR" #255

Closed
luongvo opened this issue Aug 1, 2023 · 0 comments · Fixed by #259
Assignees
Milestone

Comments

@luongvo
Copy link
Member

luongvo commented Aug 1, 2023

Why

Original RFC #219

There is a workflow to generate and update the sample project for referencing, which will be triggered on the merge commit to generate the sample project, commit and push all new changes.
Instead of generating & updating the sample project after merging new PRs into the develop, we can do it directly on each PR. That means, after making and pushing some changes in the template structure into a PR, there is a new workflow that will generate and push a new commit directly into that PR to show the new updates for the sample project.

To achieve this:

Who Benefits?

Developers

@luongvo luongvo added this to the 1.11.0 milestone Aug 1, 2023
luongvo added a commit that referenced this issue Aug 16, 2023
luongvo added a commit that referenced this issue Aug 16, 2023
luongvo added a commit that referenced this issue Aug 16, 2023
luongvo added a commit that referenced this issue Aug 21, 2023
luongvo added a commit that referenced this issue Aug 21, 2023
luongvo added a commit that referenced this issue Aug 21, 2023
luongvo added a commit that referenced this issue Aug 21, 2023
luongvo added a commit that referenced this issue Aug 21, 2023
luongvo added a commit that referenced this issue Aug 21, 2023
nmint8m added a commit that referenced this issue Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment