Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Add mirrored workflows at the root project to test the iOS app publishing workflows #169

Closed
luongvo opened this issue Mar 7, 2023 · 0 comments · Fixed by #265
Closed

[iOS] Add mirrored workflows at the root project to test the iOS app publishing workflows #169

luongvo opened this issue Mar 7, 2023 · 0 comments · Fixed by #265
Assignees
@doannimble
Labels
type : chore
Milestone
1.11.0

Comments

@luongvo
Copy link
Member

luongvo commented Mar 7, 2023 •
edited
Loading

Why

We have some workflows in the generated project for the iOS app publishing.

However, they're not actually running in this root template repository, so we don't have ways to verify their correctness. For example:

  • Both of them are missing a step to prepare the production .env file before building & deploying💥

We need to add mirrored workflows in the root template repository to test the iOS app publishing workflows like what we did in these PRs #161 and #163.

Who Benefits?

Developers
@luongvo luongvo changed the title Add mirrored workflows at the root project to test the the iOS app publishing workflows Add mirrored workflows at the root project to tes the iOS app publishing workflows Mar 7, 2023
@luongvo luongvo changed the title Add mirrored workflows at the root project to tes the iOS app publishing workflows Add mirrored workflows at the root project to test the iOS app publishing workflows Mar 7, 2023
@luongvo luongvo mentioned this issue Mar 7, 2023
Merged
@luongvo luongvo changed the title Add mirrored workflows at the root project to test the iOS app publishing workflows [iOS] Add mirrored workflows at the root project to test the iOS app publishing workflows Jul 11, 2023
@luongvo luongvo added this to the 1.11.0 milestone Aug 1, 2023
doannimble added a commit that referenced this issue Aug 7, 2023
@doannimble
[#169] Set up production env
769c32e
doannimble added a commit that referenced this issue Aug 7, 2023
@doannimble
[#169] Set up production env
0e1bce0
doannimble added a commit that referenced this issue Aug 7, 2023
@doannimble
[#169] Add iOS deploy to root
93ee4b2
doannimble added a commit that referenced this issue Aug 7, 2023
@doannimble
[#169] Remove mason syntax
662d1e2
doannimble added a commit that referenced this issue Aug 7, 2023
@doannimble
[#169] Upgrade ssh agent
c3154f5
doannimble added a commit that referenced this issue Aug 7, 2023
@doannimble
[#169] Generate new project
4cb37be
@doannimble doannimble mentioned this issue Aug 7, 2023
Merged
doannimble added a commit that referenced this issue Aug 7, 2023
@doannimble
[#169] Set up production env
97bb86a
doannimble added a commit that referenced this issue Aug 7, 2023
@doannimble
[#169] Set up production env
e9366f1
doannimble added a commit that referenced this issue Aug 7, 2023
@doannimble
[#169] Add iOS deploy to root
9d3f404
doannimble added a commit that referenced this issue Aug 7, 2023
@doannimble
[#169] Remove mason syntax
ae2b038
doannimble added a commit that referenced this issue Aug 7, 2023
@doannimble
[#169] Upgrade ssh agent
84af47d
doannimble added a commit that referenced this issue Aug 7, 2023
@doannimble
[#169] Generate new project
7ea0ea7
doannimble added a commit that referenced this issue Aug 7, 2023
@doannimble
[#169] Chagne ENV_PRODUCTION to ENV
71add25
doannimble added a commit that referenced this issue Aug 8, 2023
@doannimble
[#169] Add production suffix
f55bacf
doannimble added a commit that referenced this issue Aug 8, 2023
@doannimble
[#169] Update env values
3e2a530
doannimble added a commit that referenced this issue Aug 9, 2023
@doannimble
[#169] Use production env
7cdca83
doannimble added a commit that referenced this issue Aug 9, 2023
@doannimble
[#169] Update match keys
620634f
doannimble added a commit that referenced this issue Aug 9, 2023
@doannimble
[#169] Update Fastfile brick
158dff9
doannimble added a commit that referenced this issue Aug 9, 2023
@doannimble
[#169] Set connect API key
5e7ec0c
doannimble added a commit that referenced this issue Aug 9, 2023
@doannimble
[#169] Manual add keyId into Fastfile
14ded82
doannimble added a commit that referenced this issue Aug 9, 2023
@doannimble
[#169] Update API key
5d7bd19
doannimble added a commit that referenced this issue Aug 9, 2023
@doannimble
[#169] Run demo use constant
ecc059e
doannimble added a commit that referenced this issue Aug 29, 2023
@doannimble
[#169] Update indent for app store flow
202c714
doannimble added a commit that referenced this issue Aug 29, 2023
@doannimble
[#169] Update mustacheCase for PRIVATE KEY
b13ff9c
doannimble added a commit that referenced this issue Aug 29, 2023
@doannimble
[#169] Update sample indent
9f5248d
doannimble added a commit that referenced this issue Aug 29, 2023
@doannimble
[#169] Format Fastfile and update sample env
4b3980d
doannimble added a commit that referenced this issue Aug 31, 2023
@doannimble
[#169] Update name and indent
4fb1a3d
doannimble added a commit that referenced this issue Aug 31, 2023
@doannimble
[#169] Update APP_STORE_CONNECT_API_KEY_BASE64 name
5b4d086
doannimble added a commit that referenced this issue Aug 31, 2023
@doannimble
[#169] Update GITHUB_RUN_NUMBER
25e0826
doannimble added a commit that referenced this issue Aug 31, 2023
@doannimble
[#169] Format ios deploy files
d08a345
doannimble added a commit that referenced this issue Aug 31, 2023
@doannimble
[#169] Update echo ENV
de816c8
doannimble added a commit that referenced this issue Aug 31, 2023
@doannimble
[#169] Update set_app_store_connect_api_key name
6b78bb0
doannimble added a commit that referenced this issue Aug 31, 2023
@doannimble
[#169] Implement upload to testflight and app store flow
5828298
doannimble added a commit that referenced this issue Aug 31, 2023
@doannimble
[#169] Remove unused file
e541ea4
doannimble added a commit that referenced this issue Aug 31, 2023
@doannimble
[#169] Revert name to easy find the changes
6845fba
doannimble added a commit that referenced this issue Aug 31, 2023
@doannimble
[#169] Update indent
fa83177
doannimble added a commit that referenced this issue Aug 31, 2023
@doannimble
[#169] Update indent for app store flow
2a3709e
doannimble added a commit that referenced this issue Aug 31, 2023
@doannimble
[#169] Update mustacheCase for PRIVATE KEY
ad4971a
doannimble added a commit that referenced this issue Aug 31, 2023
@doannimble
[#169] Update sample indent
a745c66
doannimble added a commit that referenced this issue Aug 31, 2023
@doannimble
[#169] Format Fastfile and update sample env
a94a603
doannimble added a commit that referenced this issue Aug 31, 2023
@doannimble
[#169] Update name and indent
7ddf6cd
doannimble added a commit that referenced this issue Aug 31, 2023
@doannimble
[#169] Update APP_STORE_CONNECT_API_KEY_BASE64 name
9c81226
doannimble added a commit that referenced this issue Aug 31, 2023
@doannimble
[#169] Update GITHUB_RUN_NUMBER
b79e9cf
doannimble added a commit that referenced this issue Aug 31, 2023
@doannimble
[#169] Format ios deploy files
c886304
doannimble added a commit that referenced this issue Aug 31, 2023
@doannimble
[#169] Update echo ENV
c090c40
doannimble added a commit that referenced this issue Aug 31, 2023
@doannimble
[#169] Update set_app_store_connect_api_key name
4e4e688
doannimble added a commit that referenced this issue Aug 31, 2023
@doannimble
[#169] Update env name
f2b8ce4
doannimble added a commit that referenced this issue Aug 31, 2023
@doannimble
[#169] Fix missing comments
7e0beee
doannimble added a commit that referenced this issue Sep 6, 2023
@doannimble
[#169] Format spacing
9309890
doannimble added a commit that referenced this issue Sep 6, 2023
@doannimble
[#169] Format code
2e162e8
@luongvo luongvo mentioned this issue Sep 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@doannimble doannimble

Labels
type : chore
Projects
None yet
Milestone
1.11.0
2 participants
@luongvo @doannimble