Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Update android_deploy_production.yml to build and distribute release build #268

Closed
Tracked by #228
luongvo opened this issue Sep 6, 2023 · 0 comments · Fixed by #275
Closed
Tracked by #228

[Android] Update android_deploy_production.yml to build and distribute release build #268

luongvo opened this issue Sep 6, 2023 · 0 comments · Fixed by #275
Assignees
@luongvo
Labels
type : feature
Milestone
1.12.0

Comments

@luongvo
Copy link
Member

luongvo commented Sep 6, 2023 •
edited
Loading

Why

Currently, the android_deploy_production.yml workflow builds and distributes debug build without signing instead of the release build. Debug does not enable proguard so we can not verify the signing & packaging issues.

flutter-templates/.github/workflows/android_deploy_production.yml

Lines 51 to 53 in 6c98f12

# App Bundle requires Firebase connected to Play Store to upload https://appdistribution.page.link/KPoa
- name: Build Android apk
run: flutter build apk --flavor production --debug --build-number $GITHUB_RUN_NUMBER

  • We need to update the workflow to build and distribute the release build for both root & template projects.

Who Benefits?

Developers
@luongvo luongvo mentioned this issue Sep 6, 2023
Open
@luongvo luongvo modified the milestone: 1.12.0 Sep 6, 2023
@luongvo luongvo self-assigned this Oct 11, 2023
luongvo added a commit that referenced this issue Oct 25, 2023
@luongvo
[#268] Rename signing.properties to end with ".sample" to be generate…
85451e7 
…d to sample folder
luongvo added a commit that referenced this issue Oct 25, 2023
@luongvo
[#268] Update README instruction to sign release build
4980d8d
luongvo added a commit that referenced this issue Oct 25, 2023
@luongvo
[#268] Fix: Keep BuildConfig for Flutter Config https://github.com/By…
de12e5f 
…neappLLC/flutter_config/blob/master/doc/ANDROID.md#android-setup
luongvo added a commit that referenced this issue Oct 25, 2023
@luongvo
[#268] Update workflows to build Android production release build
5948a36
@luongvo luongvo mentioned this issue Oct 25, 2023
Merged
luongvo added a commit that referenced this issue Oct 25, 2023
@luongvo
[#268] Update workflows to build Android production release build
4a3720a
luongvo added a commit that referenced this issue Oct 25, 2023
@luongvo
[#268] Update workflows to build Android production release build
119af91
luongvo added a commit that referenced this issue Oct 25, 2023
@luongvo
[#268] Update CD workflows naming
c8cc399
luongvo added a commit that referenced this issue Oct 25, 2023
@luongvo
[#268] Update workflows to build Android production release build
3552064
luongvo added a commit that referenced this issue Oct 25, 2023
@luongvo
[#268] Update workflows to build Android production release build
0ec5f02
luongvo added a commit that referenced this issue Oct 25, 2023
@luongvo
[#268] Update all CD workflow naming
cb9993a
@luongvo luongvo linked a pull request Oct 25, 2023 that will close this issue
[#268] [Android] Update android_deploy_production.yml to build and distribute release build #275
Merged
@luongvo luongvo mentioned this issue Oct 31, 2023
Merged
This was referenced Nov 3, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luongvo luongvo

Labels
type : feature
Projects
None yet
Milestone
1.12.0
1 participant
@luongvo