From d1e17ef853eedd58650b9f164af16eedb0dc35cc Mon Sep 17 00:00:00 2001 From: hrxi Date: Thu, 16 May 2024 16:27:25 +0200 Subject: [PATCH] Fix reward inherent hashes The wrong hash function was used, instead `tx_hash` is correct. Fixes #2408. --- rpc-interface/src/types.rs | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/rpc-interface/src/types.rs b/rpc-interface/src/types.rs index e380f08e28..0a9d2ef141 100644 --- a/rpc-interface/src/types.rs +++ b/rpc-interface/src/types.rs @@ -653,21 +653,20 @@ pub enum Inherent { impl Inherent { pub fn try_from(hist_tx: HistoricTransaction) -> Option { - let hash = hist_tx.data.hash(); Some(match hist_tx.data { HistoricTransactionData::Basic(_) => return None, HistoricTransactionData::Equivocation(_) => return None, HistoricTransactionData::Reward(RewardEvent { - validator_address, - reward_address, + ref validator_address, + ref reward_address, value, }) => Inherent::Reward { block_number: hist_tx.block_number, block_time: hist_tx.block_time, - validator_address, - target: reward_address, + validator_address: validator_address.clone(), + target: reward_address.clone(), value, - hash, + hash: hist_tx.tx_hash().into(), }, HistoricTransactionData::Penalize(PenalizeEvent { validator_address,