Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Ratings on Touch Devices #17

Open
xml opened this issue Nov 16, 2015 · 2 comments
Open

No Ratings on Touch Devices #17

xml opened this issue Nov 16, 2015 · 2 comments
Labels

Comments

@xml
Copy link

xml commented Nov 16, 2015

Fundamentally, this lib is currently wired for a mouse: on a touch device, there's no position in state at the time that a click/tap event registers, so there's no rating available to be persisted by the clickHandler.

The only way to make it work on a touch-oriented device is to do something that has the effect of moving all the functionality of handleMouseMove into handleClick, so that the positioning calculations are performed based on the click position, and then processed in a single turn of setState along with the setState for the star ratings...

@ninjasort
Copy link
Owner

There were some other issues related to that. I've migrated some of an older PR that should resolve the issue. Would you mind checking out the touch-events branch and testing with that?

@ninjasort ninjasort added the bug label Jan 6, 2016
@hamxabaig
Copy link

Its not working in mobile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants