Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation: createClass & failed proptypes #5

Open
alechp opened this issue Oct 3, 2017 · 2 comments
Open

Deprecation: createClass & failed proptypes #5

alechp opened this issue Oct 3, 2017 · 2 comments

Comments

@alechp
Copy link

alechp commented Oct 3, 2017

Output on clean install / render:

screen shot 2017-10-03 at 3 11 16 pm

> [email protected] start .../react-sketchapp-glamorous
> npm run render


> [email protected] render .../react-sketchapp-glamorous
> skpm build --watch --run

🖨  Copied src/manifest.json in 4ms
Warning: Accessing createClass via the main React package is deprecated, and will be removed in React v16.0. Use a plain JavaScript class instead. If you're not yet ready to migrate, create-react-class v15.* is available on npm as a temporary, drop-in replacement. For more info see https://fb.me/react-create-class
Warning: Failed prop type: Invalid prop `style` of type `array` supplied to `View`, expected `object`.
    in View (created by glamorous(View))
    in glamorous(View) (created by App)
    in App
Warning: Failed prop type: Invalid prop `style` of type `array` supplied to `Image`, expected `object`.
    in Image (created by glamorous(Image))
    in glamorous(Image) (created by App)
    in view (created by View)
    in View (created by glamorous(View))
    in glamorous(View) (created by App)
    in App
Warning: Failed prop type: Invalid prop `style` of type `array` supplied to `Text`, expected `object`.
    in Text (created by glamorous(Text))
    in glamorous(Text) (created by App)
    in view (created by View)
    in View (created by glamorous(View))
    in glamorous(View) (created by App)
    in App
🛠  Built ./my-command.js in 2239ms
@nitin42
Copy link
Owner

nitin42 commented Oct 5, 2017

Yeah it gives error when rendering to sketch. I'll try to fix it later this week.

@nitin42
Copy link
Owner

nitin42 commented Oct 9, 2017

Well, this package depends on react-primitives for binding the aliases to the glamorous constructor. Seems like react-primitives relies on createClass method and the author has not updated that. As soon as he updates the codebase (with React 16), I'll fix this issue 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants